Generate font fallback data to be const. #38259
Conversation
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change |
| } | ||
| sb.write('], <int>['); | ||
| for (final String end in ends) { | ||
| sb.write('0x$end,'); |
| for (final String end in ends) { | ||
| sb.write('0x$end,'); | ||
| } | ||
| sb.writeln(']),'); |
There was a problem hiding this comment.
131 137 sb.escribir ( ' ] ) , ' ) ;eyebrowsoffire:const_fallback_data
| } | ||
| sb.write('], <int>['); | ||
| for (final String end in ends) { | ||
| sb.write('0x$end,'); |
4 participants
This is friendlier toward dart2wasm, and prevents it from generating some pathological functions that V8 chokes on.